Netlify deploy preview

https://deploy-preview-46497--material-ui.netlify.app/

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against ec938ab

@ZeeshanTamboli Manually testing this seems unnecessary. The change made is to-spec. There isn't a need to validate how screen readers announce input's with type="text" across browsers, right?

@ZeeshanTamboli The change made is to-spec.

Yes, but we should always test any changes made to code.

There isn't a need to validate how screen readers announce input's with type="text" across browsers, right?

This isn't a common case like type="text". As per discussions in #20476, there seems to be inconsistencies across browsers/screen readers. I wanted to make sure if it's resolved.

@sai6855 Are you in a position to share the results of Tree View interactions with your change using a screen reader? The change you've made is extremely valuable (thanks for doing it!) and it would be great to have the maintainers sign-off on merging it.

@ZeeshanTamboli Thank you for pushing for this to be manually tested. My apologies for suggesting otherwise.

I was just able to manually test @sai6855's PR and found it's not working as expected. With his changes, an indeterminate node is not announced as half-checked:

It looks it's actually the <li role="treeitem /> element that needs the aria-checked="mixed" added to it to announce correctly:

In fact, adding aria-checked="mixed" to the <input type="checkbox" /> had no effect (at least with NVDA). This is probably why many tree view libraries don't use an actual <input type="checkbox" /> element to represent the checkbox, but rather a styled span/div.

@ZeeshanTamboli: If @sai6855 is able to fix his PR, that'd be great. If he isn't/doesn't, I can submit a new PR, but let me know if the only desired update is to set aria-checked="mixed" to the <li role="treeitem /> element.

@mellis481 Thanks for testing it. As per MDN docs, the mixed value of aria-checked isn't supported in the native <input type="checkbox">. In fact, aria-checked is not needed for native checkbox inputs. The true and false values are supported in elements having roles switch, radio etc, but the mixed is only supported on roles checkbox and menuitemcheckbox. Now in the case of tree item, since role treeitem is inherited into roles that support aria-checked, it works there. See WAI-ARIA docs: https://www.w3.org/TR/wai-aria-1.2/#aria-checked.

Now since we want to add it on the li tree item, you will have to add this in the MUI X repository code. Feel free to create a PR there.

@ZeeshanTamboli I'll move this discussion to the MUI X issue (mui/mui-x#18740) since this PR should be closed.